ceph-osd: --flush-journal: sporadic segfaults on exit #13311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems that system will releases those resources. |
|
@liuchang0812 "system will release those resources" involves nasty things like
That's why the main code path cares to shut the OSD down properly (see https://github.com/ceph/ceph/blob/jewel/src/ceph_osd.cc#L636-L646) |
asheplyakov
force-pushed
the
master-18820
branch
from
1dec650
to
6a85265
Compare
FileStore holds a number of recources like op thread pool and work queue, key/value DB threads, etc. These should be properly stopped (released) before exiting to avoid segfaults on exit. Note: more code paths (mkfs, dump_journal, etc) need similar fixes, these will be submitted as separate patches. Fixes: http://tracker.ceph.com/issues/18820 Signed-off-by: Alexey Sheplyakov <asheplyakov@mirantis.com>
asheplyakov
force-pushed
the
master-18820
branch
from
6a85265
to
0018481
Compare
|
jenkins test this please |
liewegas
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileStore holds a number of recources like op thread pool and work
queue, key/value DB threads, etc. These should be properly stopped
(released) before exiting to avoid segfaults on exit.
Note: more code paths (mkfs, dump_journal, etc) need similar fixes,
these will be submitted as separate patches.
Fixes: http://tracker.ceph.com/issues/18820
Signed-off-by: Alexey Sheplyakov asheplyakov@mirantis.com