osd: fix stat sum update of recovery pushing #13328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the stat field of PushInfo to do the stat update, which is more accurate, especially in the case of sparse file. Also, remove the stat sum update in on_peer_recover, which is done in on_global_recover. Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com>
tchaikov
requested changes
Feb 9, 2017
|
|
||
| get_parent()->release_locks(pi->lock_manager); | ||
| object_stat_sum_t stat = pi->stat; |
There was a problem hiding this comment.
i'd suggest move this into the if (pushing[soid].empty()) { branch. and better off declare it as a reference. also where *_recovered field are set? we don't set them in ReplicatedBackend::prep_push().
There was a problem hiding this comment.
pi is erased from pushing and set to NULL before the if branch. See the two lines following.
The *_recovered fields are set in build_push_op.
tchaikov
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stat field of PushInfo to do the stat update, which is
more accurate, especially in the case of sparse file. Also,
remove the stat sum update in on_peer_recover, which is done in
on_global_recover.
Signed-off-by: Zhiqiang Wang zhiqiang@xsky.com