common: include/ceph_features.h uses uint64_t, which is in sys/types.h #13339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with Clang on FreeBSD there are lots of errors about
missing uint64_t:
In file included from /home/jenkins/workspace/ceph-master/src/msg/msg_types.cc:2:
In file included from /home/jenkins/workspace/ceph-master/src/msg/msg_types.h:20:
/home/jenkins/workspace/ceph-master/src/include/ceph_features.h:71:1: error: unknown type name 'uint64_t'
DEFINE_CEPH_FEATURE( 0, 1, UID)
^
/home/jenkins/workspace/ceph-master/src/include/ceph_features.h:14:15: note: expanded from macro 'DEFINE_CEPH_FEATURE'
const static uint64_t CEPH_FEATURE_##name = (1ULL<<bit); \
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
liewegas
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with Clang on FreeBSD there are lots of errors about
missing uint64_t:
In file included from /home/jenkins/workspace/ceph-master/src/msg/msg_types.cc:2:
In file included from /home/jenkins/workspace/ceph-master/src/msg/msg_types.h:20:
/home/jenkins/workspace/ceph-master/src/include/ceph_features.h:71:1: error: unknown type name 'uint64_t'
DEFINE_CEPH_FEATURE( 0, 1, UID)
^
/home/jenkins/workspace/ceph-master/src/include/ceph_features.h:14:15: note: expanded from macro 'DEFINE_CEPH_FEATURE'
const static uint64_t CEPH_FEATURE_##name = (1ULL<<bit); \
Signed-off-by: Willem Jan Withagen wjw@digiware.nl