rgw: fix error code of inexistence of versions location in swift api #13350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all commits in this PR are signed |
|
Build finished. |
|
jekins test this please |
rzarzynski
requested changes
Feb 13, 2017
src/rgw/rgw_rados.cc
Outdated
| @@ -6129,7 +6129,7 @@ int RGWRados::swift_versioning_copy(RGWObjectCtx& obj_ctx, | |||
| r = get_bucket_info(obj_ctx, bucket_info.bucket.tenant, bucket_info.swift_ver_location, dest_bucket_info, NULL, NULL); | |||
| if (r < 0) { | |||
| ldout(cct, 10) << "failed to read dest bucket info: r=" << r << dendl; | |||
| return r; | |||
| return -ERR_PRECONDITION_FAILED; | |||
There was a problem hiding this comment.
I think we should be more selective here. This translates to overwriting only those errors we expect like ENOENT.
when the versions location of container does not exist and uploading the same object two more times to the container, it will return 412 rather than 404 in openstack swift. Meanwhile, if the dest bucket owner is not consistent with src bucket owner, it will return 412. http://tracker.ceph.com/issues/18880 Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>
Jing-Scott
force-pushed
the
fix-swift-ver-error-code
branch
from
e3c7f1b
to
e94e267
Compare
|
@rzarzynski thanks for the suggestion! i aslo found that if the dest bucket owner is not consistent with the owner of src bucket will return 412. so i fixed it in this commit. please check it. thanks! |
rzarzynski
approved these changes
Feb 16, 2017
There was a problem hiding this comment.
LGTM. Also Tempest is fine with the change. Thanks, @Jing-Scott !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the versions location of container does not exist and uploading the same object two more times to the container, it will return 412 rather than 404 in openstack swift.
http://tracker.ceph.com/issues/18880
Signed-off-by: Jing Wenjun jingwenjun@cmss.chinamobile.com