init-ceph: print trailing n in "status" output #13351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the version command is handled by HelpHook, which does not print newline
at the end of the returned JSON. so the output of "status" subcommand
looks like:
=== osd.1 ===
osd.1: running {"version":"Development"}=== osd.2 ===
osd.2: not running.
with this change, a newline is added to the end of version.
also use the "daemon" subcommand to talk to the asok, let the "ceph" cli
to figure out the asok path.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-init-ceph-newline
branch
from
845f9a3
to
68ab318
Compare
smithfarm
approved these changes
Feb 10, 2017
|
retest this please, jenkins agent failure. |
liewegas
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version command is handled by HelpHook, which does not print newline
at the end of the returned JSON. so the output of "status" subcommand
looks like:
=== osd.1 ===
osd.1: running {"version":"Development"}=== osd.2 ===
osd.2: not running.
with this change, a newline is added to the end of version.
Signed-off-by: Kefu Chai kchai@redhat.com