rgw: add support for noncurrentversion expiration in s3 lifecycle. #13385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yehudasa @cbodley @mattbenjamin, please help to review, thanks |
dang
requested changes
Feb 16, 2017
src/rgw/rgw_lc.cc
Outdated
| bool remove_indeed = true; | ||
| int expiration; | ||
| for (auto obj_iter = objs.begin(); obj_iter != objs.end(); ++obj_iter) { | ||
| if ((*obj_iter).is_current()) { |
There was a problem hiding this comment.
Rather than (*obj_iter).foo, can you use obj_iter->foo
|
teuthology run was clean (only failures were selinux related) |
Fixes: http://tracker.ceph.com/issues/18916 Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
zhangsw
force-pushed
the
feature-lifecycle-noncurrent
branch
from
638a1cb
to
2c3a769
Compare
|
@dang I've changed to '->'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support for the non-current object version's expiration. This works if the bucket's versioning status is enabled or suspended.
S3's doc about the expiration: http://docs.aws.amazon.com/AmazonS3/latest/dev/intro-lifecycle-rules.html
Fixes: http://tracker.ceph.com/issues/18916
Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com