Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include/denc, kv: silence gcc warnings #13458

Merged
merged 2 commits into from Feb 18, 2017
Merged

include/denc, kv: silence gcc warnings #13458

merged 2 commits into from Feb 18, 2017

Commits on Feb 17, 2017

  1. include/denc: silence gcc warnings 

    gcc-7 complains:

ceph/ceph/src/include/denc.h:469:50: warning: enum constant in boolean
context [-Wint-in-bool-context]
 inline typename std::enable_if<traits::supported &&
                                ~~~~~~~~~~~~~~~~~~^~
           traits::featured>::type denc(
           ~~~~~~

so let's use "static constexpr bool" instead of enum.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    cdb3ecb View commit details
    Browse the repository at this point in the history

  2. kv: silence the gcc warning of func foo was hidden 

    this silences the warnings like

ceph/ceph/src/kv/KeyValueDB.h:59:18: warning: ‘virtual void
KeyValueDB::TransactionImpl::set(const string&, const char*, size_t,
const bufferlist&)’ was hidden [-Woverloaded-\
virtual]
     virtual void set(
                  ^~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    7251ea5 View commit details
    Browse the repository at this point in the history