wip: rgw: rest_admin/user avoid double checking input args #13460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all the op_state functions already check for string emptiness, the check in the execute function becomes redundant. A TODO to knockdown is validate that the required args are passed in, we currently return 403s instead of 400 even when required args for eg. uid are not passed in Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
changed the title
|
we could validate the required params as well, one possible way is to use the bool from |
cbodley
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all the op_state functions already check for string emptiness, the
check in the execute function becomes redundant.
Another TODO to knockdown is validate that the required args are passed in, we
currently return 403s instead of 400 even when required args for eg. uid
are not passed in
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com