msg, messages: coverity fixes

[tchaikov]

No description provided.

[gregsfortytwo]

Did you check the history on these? I don't recognize them but the warning made me concerned they are meant to do something (say, sanitize the feature list into something we understand?) via C++ magic that has failed.

[tchaikov]

@gregsfortytwo i did check the history as this statement is quite weird from the first glance. they were meant to do something. the commit Sage changed to this is ff19592. and ceph_sanitize_features() has gone. i see no reason to keep the foo = foo around anymore.

[liewegas]

Yep, I was just sloppy removing the sanitize call!

[byo]

This does not compile. Please initialize with SCALE_LINEAR.

[tchaikov]

fixed and repushed.

[byo]

@tchaikov huh, the fix won't be that easy, adding default values removed default constructors.

Not that pretty but works:

  struct axis_config_d {
    explicit axis_config_d(const char *name = nullptr,
                           scale_type_d scale_type = SCALE_LINEAR,
                           int64_t min = 0, int64_t quant_size = 0,
                           int32_t buckets = 0)
        : m_name(name),
          m_scale_type(scale_type),
          m_min(min),
          m_quant_size(quant_size),
          m_buckets(buckets) {}

    const char *m_name;
    scale_type_d m_scale_type;
    int64_t m_min;
    int64_t m_quant_size;
    int32_t m_buckets;
  };

[tchaikov]

@dillaman i dropped the rbd-nbd changes from this PR, we can come back later with better idea later.

[tchaikov]

http://pulpito.ceph.com/kchai-2017-02-18_07:48:13-rados-wip-kefu-testing-2---basic-smithi/