mon/OSDMonitor: fix dividing by zero in OSDUtilizationDumper #13531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiumxNL
changed the title
LiumxNL
force-pushed
the
fix-osd-utilization
branch
from
bfdc4b7
to
e65e161
Compare
tchaikov
requested changes
Feb 20, 2017
src/mon/OSDMonitor.cc
Outdated
| @@ -641,7 +641,10 @@ class OSDUtilizationDumper : public CrushTreeDumper::Dumper<F> { | |||
| int64_t kb = 0, kb_used = 0, kb_avail = 0; | |||
| double util = 0; | |||
| if (get_bucket_utilization(qi.id, &kb, &kb_used, &kb_avail)) | |||
| if (kb_used) { | |||
| assert(kb > 0); | |||
There was a problem hiding this comment.
this does not fix the divide by zero issue. if kb is 0, monitor crashes as before.
Signed-off-by: Mingxin Liu <mingxin@xsky.com>
LiumxNL
force-pushed
the
fix-osd-utilization
branch
from
e65e161
to
9fe1032
Compare
|
LGTM |
|
@tchaikov updated |
tchaikov
approved these changes
Feb 21, 2017
tchaikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mingxin Liu mingxin@xsky.com