mon/OSDMonitor: make mapping job behave if mon_osd_prime_pg_temp = false #13574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
Feb 22, 2017
| dout(10) << __func__ << " started mapping job " << mapping_job.get() | ||
| << " at " << fin->start << dendl; | ||
| mapping_job->set_finish_event(fin); | ||
| if (g_conf->mon_osd_prime_pg_temp) { |
There was a problem hiding this comment.
this fixes http://tracker.ceph.com/issues/19020 also, as src/test/erasure-code/test-erasure-code.sh sets mon_osd_prime_pg_temp to false.
could you add a "Fixes" tag in the commit message?
Make this robust to changes online too, so that we clean up a mapping job that was started, but only use it or start a new one if the option is true. Fixes: http://tracker.ceph.com/issues/19020 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-mon-mapping
branch
from
9f2d57a
to
e00ef43
Compare
|
updated! |
retest this please. |
|
@tchaikov that failure looks unrelated. do you remember which test case it was though? |
|
@liewegas i think it's another form of http://tracker.ceph.com/issues/17743. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this robust to changes online too, so that we clean up a mapping
job that was started, but only use it or start a new one if the
option is true.
Signed-off-by: Sage Weil sage@redhat.com