rgw_file: wip parentref #13607
Merged
rgw_file: wip parentref #13607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These refs won't be returned by nfs-ganesha, and are sufficiently magical that other consumers should be persuaded to understand their specialness. Fixes: http://tracker.ceph.com/issues/19060 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
cbodley
reviewed
Feb 23, 2017
src/include/rados/rgw_file.h
Outdated
| @@ -91,6 +91,7 @@ void rgwfile_version(int *major, int *minor, int *extra); | |||
| */ | |||
| #define RGW_LOOKUP_FLAG_NONE 0x0000 | |||
| #define RGW_LOOKUP_FLAG_CREATE 0x0001 | |||
| #define RGW_LOOKUP_FLAG_RCB 0x0002 | |||
There was a problem hiding this comment.
the meaning of RCB is not immediately obvious here, a comment would be helpful
Allow callers of rgw_lookup() on objects attested in an rgw_readdir() callback the ability to bypass exact match in RGWLibFS::stat_leaf() case 2, but restore exact match enforcement for general lookups. This preserves required common_prefix namespace behavior, but prevents clients from eerily permitting things like "cd sara0" via partial name match on "sara01." Fixes: http://tracker.ceph.com/issues/19059 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-parentref
branch
from
c26190d
to
70ef7d4
Compare
|
@cbodley updated |
cbodley
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
http://tracker.ceph.com/issues/19060
http://tracker.ceph.com/issues/19059