-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: misc minor fixes #13713
doc: misc minor fixes #13713
Conversation
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc/install/install-ceph-gateway.rst
Outdated
performance degradation when users place large numbers of objects into a | ||
bucket. | ||
defaults to ``.rgw.buckets.index``. Sometimes, users like to put many objects | ||
(hundreds of thousands to millions of objects) in a single bucket. If you did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why s/do/did/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "do", you are right.
doc/install/install-ceph-gateway.rst
Outdated
(hundreds of thousands to millions of objects) in a single bucket. If you did | ||
not set quotas for the maximum number of objects per bucket using the gateway | ||
administration interface, the bucket index can suffer significant | ||
performance degradation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think "when users place large numbers of objects into a bucket" is redundant here. you could put
In this case, if you do not ....
to connect the precondition to its consequence.
@@ -321,7 +321,7 @@ For ``bind``, add a wildcard to the DNS record. For example:: | |||
* IN CNAME @ | |||
|
|||
Restart your DNS server and ping your server with a subdomain to ensure that | |||
your ``ceph-radosgw`` daemon can process the subdomain requests:: | |||
your DNS configuration works as expected:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iiuc, the purpose of setting the DNS record is to enable radosgw to process the subdomain request. so the original doc also makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ceph-radosgw is checked in section "Create a Gateway Instance", I think it's clerical mistake here.
the "make check" failure is addressed by #13685 |
doc/install/install-ceph-gateway.rst
Outdated
not set quotas for the maximum number of objects per bucket using the gateway | ||
administration interface, the bucket index can suffer significant | ||
performance degradation. | ||
defaults to ``.rgw.buckets.index``. Sometimes users like to put many objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please just remove the commit being reverted?
The doc compiler complains about this. Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
Improper commit removed according to advice of @tchaikov |
No description provided.