rgw_file: fix reversed return value of getattr #13895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ::getattr returns -ESTALE, rgw_getattr returns ESTALE, which is a not expected postive. Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
|
@mattbenjamin any comments on this? |
|
@guihecheng actually, I think that the pattern is evolving to be RGWLibFS:: (for all operations) should return an already sign-corrected result. As I read the code, RGWLibFS::getattr() will in fact return -ESTALE, so we don't want to sign-reverse it, right? |
|
@mattbenjamin yes, actually ganesha FSAL_RGW always take a negative retcode for errors, so here we should keep the negative one. |
mattbenjamin
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ::getattr returns -ESTALE, rgw_getattr returns ESTALE,
which is a not expected postive.
Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com