os/bluestore/NVMEDevice: add the spdk core mask check #14068
Conversation
src/os/bluestore/NVMEDevice.cc
Outdated
|
|
||
| if (sn_tag.empty()) { | ||
| r = -ENOENT; | ||
| derr << __func__ << " empty serial number: " << cpp_strerror(r) << dendl; | ||
| return r; | ||
| } | ||
|
|
||
| core_value = strtoll(g_conf->bluestore_spdk_coremask.c_str(), NULL, 16); | ||
| for (int i = 0; i < 64; i++) { |
There was a problem hiding this comment.
@yuyuyu101 I updated this code, it used to check the each bit in core_value.
There was a problem hiding this comment.
@yuyuyu101 I updated this code, it used to check the each bit in core_value.
There was a problem hiding this comment.
@yuyuyu101 I updated this code, it used to check the each bit in core_value.
There was a problem hiding this comment.
@yuyuyu101 I updated this code, it used to check the each bit in core_value.
|
@yuyuyu101 I updated this code, it used to check each bit in core_value. |
|
this patch tested and worked well in my ceph，and solve the issues ( http://tracker.ceph.com/issues/19093) my osd config is that： [osd.1] |
src/os/bluestore/NVMEDevice.cc
Outdated
| // at least two cores are needed for using spdk | ||
| if (core_num < 2) { | ||
| r = -ENOENT; | ||
| derr << __func__ << " invalid spdk coremask: " << cpp_strerror(r) << dendl; |
There was a problem hiding this comment.
suggest explicitly tell the reason like at least two cores needed
This patch adds the spdk core mask check and also set the master core for starting DPDK. Signed-off-by: optimistyzy <optimistyzy@gmail.com>
|
updated with suggested comments. @yuyuyu101 |
yuyuyu101
changed the title
This patch adds the spdk core mask check and also
set the master core for starting DPDK.
Signed-off-by: optimistyzy optimistyzy@gmail.com