Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add support for "end_marker" parameter for GET on Swift account. #4216

Merged
merged 2 commits into from Jan 8, 2016

Conversation

rzarzynski
Copy link
Contributor

No description provided.

@loic-bot
Copy link

SUCCESS: the output of run-make-check.sh on centos-7 for 9ed450a is http://paste2.org/ZLtUssJh

:octocat: Sent from GH.

@rzarzynski
Copy link
Contributor Author

@yehudasa reworked according to your suggestions.

Original branch: https://github.com/rzarzynski/ceph/tree/wip-10682-old-1.

@rzarzynski
Copy link
Contributor Author

@yehudasa rebased due to merge conflict.

@yehudasa
Copy link
Member

@rzarzynski this looks fine. How has it been tested? Did you run the s3-tests suite against it?

@rzarzynski
Copy link
Contributor Author

@yehudasa rebased due to merge conflict.
I'm attaching the results from s3-tests against current master and this branch.

@rzarzynski
Copy link
Contributor Author

@yehudasa it looks that we have some problem. Tested on vanilla master (e24509b; without this PR):

$ curl -i http://localhost:8000/swift/v1/ -X GET -H "X-Auth-Token: $token"
HTTP/1.1 204 No Content
X-Timestamp: 1430311840.68982
X-Account-Container-Count: 0
X-Account-Object-Count: 0
X-Account-Bytes-Used: 0
X-Account-Bytes-Used-Actual: 0
Content-Length: 1
Accept-Ranges: bytes
Date: Wed, 29 Apr 2015 12:50:40 GMT

$ curl -i http://localhost:8000/swift/v1/cont -X PUT -H "X-Auth-Token: $token"
HTTP/1.1 201 Created
Content-Length: 0
Accept-Ranges: bytes
Date: Wed, 29 Apr 2015 12:50:56 GMT

$ curl -i http://localhost:8000/swift/v1/ -X GET -H "X-Auth-Token: $token"
HTTP/1.1 200 OK
X-Timestamp: 1430311859.43158
X-Account-Container-Count: 0
X-Account-Object-Count: 0
X-Account-Bytes-Used: 0
X-Account-Bytes-Used-Actual: 0
Content-Length: 1
Accept-Ranges: bytes
Date: Wed, 29 Apr 2015 12:50:59 GMT

c

@yehudasa
Copy link
Member

@rzarzynski do we still have that problem?

@rzarzynski
Copy link
Contributor Author

@yehudasa rebased due to merge conflict. Retested using both s3-tests and Tempest - no regression detected in comparison to current master (7fbf013).

@rzarzynski
Copy link
Contributor Author

@yehudasa rebased to master due to a merge conflict.

@rzarzynski
Copy link
Contributor Author

@yehudasa output from yesterday test run:

In short summary:

  • s3-tests against wip-10682: FAILED (SKIP=4, errors=4, failures=6);
  • s3-tests against master: FAILED (SKIP=4, errors=4, failures=6);
  • Tempest against wip-10682: FAILED (id=618, failures=46 (-77), skips=2);
  • Tempest against master: FAILED (id=619, failures=46, skips=2).

@rzarzynski
Copy link
Contributor Author

@yehudasa switched to const string&.

@yehudasa
Copy link
Member

Will open a new pull request for this that will include my changes and fixes

@yehudasa yehudasa closed this Aug 28, 2015
@yehudasa yehudasa reopened this Aug 28, 2015
@yehudasa
Copy link
Member

oops, closed the wrong PR

@rzarzynski
Copy link
Contributor Author

@yehudasa rebased due to a small merge conflict.

Fixes: ceph#10682
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
@rzarzynski
Copy link
Contributor Author

@yehudasa rebased due to small conflicts with wip-5073.

yehudasa added a commit that referenced this pull request Jan 8, 2016
rgw: add support for "end_marker" parameter for GET on Swift account.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
@yehudasa yehudasa merged commit 4ada558 into ceph:master Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants