Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: os/bluestore: Always update the cursor position in AVL near-fit search. #45885

Merged
merged 1 commit into from
Apr 14, 2022
Merged

quincy: os/bluestore: Always update the cursor position in AVL near-fit search. #45885

merged 1 commit into from
Apr 14, 2022

Conversation

markhpc
Copy link
Member

@markhpc markhpc commented Apr 13, 2022

Quincy backport of #45884

Signed-off-by: Mark Nelson mnelson@redhat.com

@github-actions github-actions bot added this to the quincy milestone Apr 13, 2022
@ifed01
Copy link
Contributor

ifed01 commented Apr 13, 2022

Generally LGTM, just one note. Our best practice is to cherry-pick commits from master when backporting. AFAIU that's not the case for this PR. Do we really need that deviation from the rules?

@markhpc
Copy link
Member Author

markhpc commented Apr 13, 2022

@ifed01 After discussion yesterday at the rados meeting I thought @neha-ojha wanted to cherry-pick from the PR so the two PRs could be run through QA in parallel to get the quincy release out the door this week. I don't typically do backports though so I apologize if it's a deviation from normal behavior.

@ifed01
Copy link
Contributor

ifed01 commented Apr 13, 2022

@ifed01 After discussion yesterday at the rados meeting I thought @neha-ojha wanted to cherry-pick from the PR so the two PRs could be run through QA in parallel to get the quincy release out the door this week. I don't typically do backports though so I apologize if it's a deviation from normal behavior.
Got it.
So IMO it makes sense to leave it as-is for QA but do a proper "cherry-pick -x" before merging then.

@neha-ojha
Copy link
Member

@ifed01 After discussion yesterday at the rados meeting I thought @neha-ojha wanted to cherry-pick from the PR so the two PRs could be run through QA in parallel to get the quincy release out the door this week. I don't typically do backports though so I apologize if it's a deviation from normal behavior.
Got it.
So IMO it makes sense to leave it as-is for QA but do a proper "cherry-pick -x" before merging then.

@ifed01 Yes, I've asked @markhpc to update the commit. Like Mark mentioned, my aim was to expedite the merge of this fix in quincy.

@neha-ojha
os/bluestore: Always update the cursor position in AVL near-fit search.
9fccb0c 
Signed-off-by: Mark Nelson <mnelson@redhat.com>
(cherry picked from commit 3bed53d)
@neha-ojha
Copy link
Member

Changelog:

  • force-push to fix git cherry-pick -x

@neha-ojha
Copy link
Member

jenkins test make check

@markhpc
Copy link
Member Author

markhpc commented Apr 14, 2022

@neha-ojha Thanks, you beat me to it. :)

@ifed01
Copy link
Contributor

ifed01 commented Apr 14, 2022

jenkins test make check

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/?branch=wip-yuri-testing-2022-04-13-0703-quincy

Failures in the initial run were due to infrastructure, and therefore unrelated.
All jobs were green in the final re-run.

@yuriw
Copy link
Contributor

yuriw commented Apr 14, 2022

jenkins test make check

@neha-ojha neha-ojha merged commit 2c8d01f into ceph:quincy Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@ifed01 ifed01 ifed01 approved these changes

@aclamk aclamk Awaiting requested review from aclamk

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
backport: no-conflicts Backport without conflicts bluestore bug-fix core performance wip-yuri-testing
Projects
None yet
Milestone
quincy
6 participants
@markhpc @ifed01 @neha-ojha @ljflores @yuriw @jdurgin