rgw: Keystone PKI token expiration is not enforced #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ceph#11367 Currently token expiration is only checked by the token cache. With PKI tokens no expiration check is done after decoding the token. This causes PKI tokens to be valid indefinitely. UUID tokens are validated by keystone after cache miss so they are not affected by this bug. This commit adds explicit token expiration check to RGWSwift::validate_keystone_token() Signed-off-by: Anton Aksola <anton.aksola@nebula.fi> Reported-by: Riku Lehto <riku.lehto@nexetic.com> (cherry picked from commit 2df0693)
|
@yehudasa This has passed the first run of integration tests for hammer backports, tracked at http://tracker.ceph.com/issues/11990#rgw Do you think it is ready to merge? |
|
@theanalyst yes |
ghost
pushed a commit
that referenced
this pull request
Jul 8, 2015
Keystone PKI token expiration is not enforced Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11722