objecter: resend linger ops on split #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Just <sam.just@inktank.com> (cherry picked from commit 2ee3551)
Watch/notify ops need to be resent after a pg split occurs, as well as a few other circumstances that the existing objecter checks did not catch. Refactor the check the OSD uses for this to add a version taking the more basic types instead of the whole OSD map, and stash the needed info when an op is sent. Fixes: ceph#9806 Backport: giant, firefly, dumpling Signed-off-by: Josh Durgin <josh.durgin@inktank.com> (cherry picked from commit cb9262a) Conflicts: src/osd/osd_types.cc src/osdc/Objecter.cc Minor differences.
smithfarm
force-pushed
the
wip-11699-firefly
branch
from
9206064
to
d296120
Compare
smithfarm
changed the title
|
ready for integration testing |
smithfarm
changed the title
ghost
changed the title
|
Sam is the ultimate authority on splitting pg and he also authored the original patch. |
|
@athanatos this backport passed a rados suite ( http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi ), do you think it can be merged in firefly ? |
jdurgin
added a commit
that referenced
this pull request
Jul 21, 2015
objecter: resend linger ops on split Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
Looks like a good backport to me. I authored the original 2nd patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11699