osd: FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the snaps vector is: 10=[9,5,2]:[4]+head, the backing pool's snaps vector is 3=[2]:[]+head, and we request clone 4 from the backing pool, the backing pool will send us head with an empty results->snaps vector. Actually, clone 4 should be trimmed, but the cache pool does not know that. Thus, we should construct an empty snaps vector for that clone. PartialFix: ceph#11296 Backport: firefly, hammer Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit a45a698)
If results->snaps winds up empty after filtering removed snaps, we need to treat the object as if we had gotten an ENOENT. PartialFix: ceph#11296 Backport: firefly, hammer Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 6150757)
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 16, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this hammer backport looks good to merge ? It went through a rados suite ( http://tracker.ceph.com/issues/11990#rados ). There was a transient error ( http://tracker.ceph.com/issues/12469 ) but I don't think it's related. |
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
…ade:giant-x-hammer-distro-basic-multi run Reviewed-by:
|
@liewegas ping ? |
liewegas
added a commit
that referenced
this pull request
Jul 31, 2015
FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11983