Thread.h: move copy constructor and assignment op #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
The way I understand it is that explicit is a safeguard to prevent code that would rely on implicit constructors by mistake. |
|
What difference does it make if the copy constructor is not defined? |
|
@stiopaa1 i tend to agree with you. but since we are using C++11 in master, probably we could " |
|
Agreed, will change that to use c++11's 'delete'. |
Disable copy constructor and assignment operator. They are currently not defined, so any attempt to use them will result in linker error. Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
stiopaa1
force-pushed
the
ThreadMoveCopyConstr
branch
from
53264b1
to
7080e0f
Compare
tchaikov
added a commit
that referenced
this pull request
Nov 2, 2015
Thread.h: disable copy constructor and assignment op Reviewed-by: Kefu Chai <kchai@redhat.com>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move copy constructor and assignemnt operator under the private access
specifier. They are not defined and it makes it confusing when they are
under public. They also don't need const and explicit specifiers.
Signed-off-by: Michal Jarzabek stiopa@gmail.com