fs: MDSMonitor: handle MDSBeacon messages properly #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msg.get_session() should always return a non-zero pointer in Monitor.dispatch() Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 16e8e2c) Conflicts: src/mon/Monitor.cc Monitor::_ms_dispatch(Message *m) is bool in firefly
so the peon can remove the ignored mdsbeacon request from the routed_requets at seeing this reply, and hence no longer resend the request. Fixes: ceph#11590 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 72a37b3)
* s/ignore/reply/ * s/out/ignore/ Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f00ecb8) Conflicts: src/mon/MDSMonitor.cc Do not compare known daemon health with m->get_health()
the MDS (Beacon) is always expecting the reply for the mdsbeacon messages from the lead mon, and it uses the delay as a metric for the laggy-ness of the Beacon. when it comes to the MDSMonitor on a peon, it will remove the route session at seeing a reply (route message) from leader, so a reply to mdsbeacon will stop the peon from resending the mdsbeacon request to the leader. if the MDSMonitor re-forwards the unreplied requests after they are outdated, there are chances that the requests reflecting old and even wrong state of the MDSs mislead the lead monitor. for example, the MDSs which sent the outdated messages could be dead. Fixes: ceph#11590 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit b3555e9)
|
@tchaikov pls review |
|
ping @tchaikov |
|
@tchaikov, @gregsfortytwo This has passed a rados suite (see http://tracker.ceph.com/issues/11644#rados for details). OK to merge, do you think? |
|
sorry for the latency. lgtm. |
smithfarm
added a commit
that referenced
this pull request
Sep 9, 2015
MDSMonitor: handle MDSBeacon messages properly Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11980