hammer: mon: MonitorDBStore: get_next_key() only if prefix matches #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
@jecluis could this backport be the cause of these failures : http://pulpito.ceph.com/loic-2015-08-15_22:14:11-upgrade:hammer-hammer-backports---basic-multi/ ? (see more at http://tracker.ceph.com/issues/12701#note-10) |
|
@dachary I don't think so, but feel free to test without it. Besides, the stack trace in the tracker issue feels a lot more related with memory issues rather than the store itself, but I may be wrong. |
|
@jecluis thanks for taking a look. Running the upgrade suite again to figure out if it's a permanent error or something else. http://pulpito.ceph.com/loic-2015-08-19_12:26:39-upgrade:hammer-hammer-backports---basic-vps/ |
ghost
changed the title
|
@jecluis running the hammer upgrade suite after removing this commit works. It's easy to reproduce, it fails all upgrade jobs. |
|
Also cherry-pick #5834 to make it work |
|
patch to be cherry-picked is 70d3108 |
We introduced a significant bug with 2cc7aee, when we fixed issue #11786. Although that patch would fix the problem described in #11786, we managed to not increment the iterator upon returning the current key. This would have the iterator iterating over the same key, forever and ever. Signed-off-by: Joao Eduardo Luis <joao@suse.de> (cherry picked from commit 70d3108)
|
Patch has been cherry-picked. Okay to test. |
ghost
changed the title
|
@jecluis thanks ! |
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 8, 2015
… prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 4, 2015
mon: MonitorDBStore: get_next_key() only if prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
mon: MonitorDBStore: get_next_key() only if prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
mon: MonitorDBStore: get_next_key() only if prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
mon: MonitorDBStore: get_next_key() only if prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
mon: MonitorDBStore: get_next_key() only if prefix matches Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12483