Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: register_new_pgs() should check ruleno instead of its index #5377

Merged
1 commit merged into from Sep 7, 2015
Merged

mon: register_new_pgs() should check ruleno instead of its index #5377

1 commit merged into from Sep 7, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2015

@XinzeChi @ldachary
mon/PGMonitor: bug fix pg monitor get crush rule
43a72e4 
when some rules have been deleted before, the index in array of crush->rules
is not always equals to crush_ruleset of pool.

Fixes: #12210
Reported-by: Ning Yao <zay11022@gmail.com>
Signed-off-by: Xinze Chi <xmdxcxz@gmail.com>
(cherry picked from commit 4987933)
@ghost ghost self-assigned this Jul 28, 2015
@ghost ghost added this to the hammer milestone Jul 28, 2015
@ghost ghost added bug-fix core labels Jul 28, 2015
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6698/

ghost pushed a commit that referenced this pull request Jul 29, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
52a900e 
…ead of its index

Reviewed-by:
@ghost
Copy link
Author

ghost commented Aug 30, 2015

@tchaikov does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ).

ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
494efb9 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
e0c3c96 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
fa42f30 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
0dc1d3f 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Sep 1, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
46ca458 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Sep 2, 2015
@ldachary
Merge pull request #5377: register_new_pgs() should check ruleno inst…
6060dfc 
…ead of its index

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Sep 6, 2015

@tchaikov ping ?

@ghost ghost assigned tchaikov and unassigned ghost Sep 6, 2015
@tchaikov
Copy link
Contributor

tchaikov commented Sep 7, 2015

👍

@tchaikov tchaikov assigned ghost and unassigned tchaikov Sep 7, 2015
ghost pushed a commit that referenced this pull request Sep 7, 2015
Merge pull request #5377 from dachary/wip-12396-hammer
f25315c 
register_new_pgs() should check ruleno instead of its index

Reviewed-by: Kefu Chai <kchai@redhat.com>
@ghost ghost merged commit f25315c into ceph:hammer Sep 7, 2015
@ghost ghost changed the title register_new_pgs() should check ruleno instead of its index mon: register_new_pgs() should check ruleno instead of its index Sep 13, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix core
Projects
None yet
Milestone
hammer
3 participants
@loic-bot @tchaikov @XinzeChi