librbd: support eventfd for AIO completion notifications #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
2 times, most recently
from
51335be
to
a19a61e
Compare
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
67cd704
to
5415f2e
Compare
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
5415f2e
to
8c24267
Compare
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
8c24267
to
d2a97de
Compare
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
a23b84b
to
1912157
Compare
| #define CEPH_COMMON_EVENT_TYPE_H | ||
|
|
||
| #define EVENT_SOCKET_TYPE_NONE 0 | ||
| #define EVENT_SOCKET_TYPE_PIPE 1 |
There was a problem hiding this comment.
Need librbd API exposed version of _PIPE and _EVENTFD. Since this file isn't part of the API, might as well move to an enum within event_socket.h?
There was a problem hiding this comment.
What if user specify notify type? like rbd_set_image_notification
There was a problem hiding this comment.
That's my concern -- this header file isn't part of the API so the end-user won't have access to it. My suggestion is to create librbd specific aliases for these values in librbd.h (similar to how librados aliases own flag constants within the API).
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
3 times, most recently
from
3d83a69
to
9c884da
Compare
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
9c884da
to
60c06d8
Compare
|
updated @dillaman |
|
@yuyuyu101 can you rebase and repush? |
EventSocket will wrap different user event notification method like linux eventfd, solaris port. Caller can user this to replace signal Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
1ed1c60
to
6f81e9e
Compare
|
@dillaman done |
| TP_FIELDS( | ||
| ctf_integer_hex(void*, imagectx, imagectx) | ||
| ctf_integer(int, numcomp, numcomp) | ||
| ctf_integer(int, max, max) |
dillaman
changed the title
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Since xlist clear method invoked below is enough to disassociate the xlist item from the xlist, so the remove_myself() call in the destructor is safe to invoke since it's already been removed from the list. Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-librbd-ap
branch
from
6f81e9e
to
c57ceff
Compare
dillaman
pushed a commit
that referenced
this pull request
Dec 1, 2015
librbd: support eventfd for AIO completion notifications Reviewed-by: Jason Dillaman <dillaman@redhat.com>
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently librbd support aio_read/write with specified
callback(AioCompletion). It would be nice for simple caller logic, but
it also has some problems:
littleweight" job, especially when "callback" need to update some status with lock hold