require osds are hammer v0.94.4 or later before upgrading past hammer #5686
Conversation
This is to constrain upgrades past hammer to version that include the appropriate compatibility fixes (e.g., hobject_t encoding). Signed-off-by: Sage Weil <sage@redhat.com>
- Do not allow post-hammer OSDs to start if the running hammer is not a new enough hammer. - Do not allow pre-hammer or old hammer OSDs to start once post-hammer OSDs are in the cluster. Signed-off-by: Sage Weil <sage@redhat.com>
…nning Old OSDs don't understand us. This is useful if the osd is upgraded before the mons. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-hammer-feature
branch
from
47c650f
to
38465f0
Compare
|
see also #5687 |
|
passed wip-sage-testing |
|
@liewegas would you like me to write a hammer-x test that verifies this ? |
|
@dachary that would be awesome |
ghost
self-assigned this
|
building liewegas-wip-hammer-feature in the gitbuilders |
teuthology-openstack --throttle 2 --verbose --key-name myself --key-filename ~/Downloads/myself --suite-branch wip-13026-hammer-stop --ceph liewegas-wip-hammer-feature --suite upgrade/hammer-x/v0-94-4-stop If I read the logs correctly, the >= v0.94.4 OSD restarts despite two other OSDs being < v0.94.4. The teuthology test is at https://github.com/ceph/ceph-qa-suite/pull/560/files |
|
On Fri, 11 Sep 2015, Loic Dachary wrote:
That's okay.. you just can't upgrade to infernalis if osds are < 0.94.4... |
But that's what I read : the infernalis (9.0.3 +) OSD starts and joins the cluster which has an infernalis mon despite the two 0.94.3 OSDs running. Unless I'm misreading the logs ? |
|
I should add a test for liewegas@38465f0 though. I believe the current test only covers liewegas@f668c6c |
|
Oh, I think I understand what I'm getting wrong |
|
https://github.com/ceph/ceph-qa-suite/pull/560/files passes with this pull request: teuthology-openstack --throttle 2 --verbose --key-name myself --key-filename ~/Downloads/myself --suite-branch wip-13026-hammer-stop --ceph liewegas-wip-hammer-feature --suite upgrade/hammer-x/v0-94-4-stop |
|
Not merging because it has the wip-sage-testing label. Reviewed-by: Loic Dachary <ldachary@redhat.com> once it's merged I'll write a test for #5687 as well. |
require osds are hammer v0.94.4 or later before upgrading past hammer Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
wip-sage-testing is fine, was just making sure i hadn't broken something stupid. Merged them both. We should manually (or automatically?) verify that this prevents what it's supposed to... |
Once https://github.com/ceph/ceph-qa-suite/pull/560/files is merged it will automatically verify that it does what it's supposed to for the master branch. |
No description provided.