hammer: mon: map_cache can become inaccurate if osd does not receive the osdmaps #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dachary turns out we should backport "less" than you did in #5756.
|
|
needs rebase |
tchaikov
force-pushed
the
wip-12835-hammer
branch
from
4808e21
to
8dd88b0
Compare
ghost
changed the title
* remove osd_epoch<osd, epoch> from OSDMonitor * add osd_epoch to MonSession to track the latest osdmap epoch OSDMonitor sends to a mon client * do not remove osd_epoch entries if an OSD is down, or max_osd > osd_id Fixes: ceph#10930 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit c05753e)
previously, we only track the osd_epoch for OSD peers. but other MonClients who receives osdmaps can also benefit from osd_epoch. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit de43a02) Conflicts: src/mon/OSDMonitor.cc: do not assume that the MonSession is always available when OSDMonitor::send_incremental() is called. as when the connection to the mon client is dropped, the Monitor is aware of this, but not the OSDMonitor.
tchaikov
force-pushed
the
wip-12835-hammer
branch
from
8dd88b0
to
171fee1
Compare
|
removed the assertion for the MonSession, will rerun some of the failed test once the build is ready. |
|
@dachary the test passed at http://pulpito.ceph.com/kchai-2015-11-03_00:33:48-rados:thrash-wip-5773-hammer---basic-multi/ could you take a look at this pr again? thanks! |
tchaikov
changed the title
|
@tchaikov ok, thanks ! |
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 13, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 13, 2015
… does not receive the osdmaps Reviewed-by:
ghost
pushed a commit
that referenced
this pull request
Nov 16, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
… does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-28 for details ). |
ghost
pushed a commit
that referenced
this pull request
Nov 21, 2015
mon: map_cache can become inaccurate if osd does not receive the osdmaps Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12835