tests: ceph-fuse crash in test_client_recovery #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a proxy read happens, the object promotion is done in parallel. The
agent_choose_mode function must be called to reconsider the situation
to protect against the following scenario:
* proxy read
* agent_choose_mode finds no object exists and the agent
goes idle
* object promotion happens
* the agent does not reconsider and eviction does not happen
although it should
http://tracker.ceph.com/issues/12673 Fixes: ceph#12673
Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit e1f58fe)
Verify that an object promoted to a cache tier because of a proxy read is evicted as expected. http://tracker.ceph.com/issues/12673 Refs: ceph#12673 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 7924231) Conflicts: qa/workunits/cephtool/test.sh resolved by manually adding the new test to TESTS
|
@dachary could you look at the conflict resolution on 2c0d7fe ? |
$ commit=2c0d7fe ; picked_from=$(git show --no-patch --pretty=%b $commit | perl -ne 'print if(s/.*cherry picked from commit (\w+).*/$1/)') ; diff -u --ignore-matching-lines '^[^+-]' <(git show $picked_from) <(git show $commit)
--- /dev/fd/63 2015-09-04 17:26:58.337060413 +0200
+++ /dev/fd/62 2015-09-04 17:26:58.337060413 +0200
@@ -65,11 +70,11 @@
function test_tiering()
{
# tiering
-@@ -1686,6 +1729,7 @@ MON_TESTS+=" mon_ping"
- MON_TESTS+=" mon_deprecated_commands"
-
- OSD_TESTS+=" osd_bench"
-+OSD_TESTS+=" tiering_agent"
-
- MDS_TESTS+=" mds_tell"
- MDS_TESTS+=" mon_mds"
+@@ -900,6 +943,7 @@ set +x
+ TESTS=(
+ mon_injectargs_SI
+ tiering
++ tiering_agent
+ auth
+ mon_misc
+ mon_mds
|
|
the actual conflict resolution matches the description |
Reviewed-by: Loic Dachary <ldachary@redhat.com> once the tests pass |
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
ceph-fuse crash in test_client_recovery Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12882