msg/async: support of non-block connect in async messenger #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (r < 0) { | ||
| if (r == -EINPROGRESS || r == -EALREADY) | ||
| break; | ||
| goto fail; |
There was a problem hiding this comment.
plz add level 1 error log above "goto"
zuiwanyuan
force-pushed
the
wip-nonblock-connect
branch
from
a913b67
to
2994073
Compare
|
LGTM |
|
Tested in http://pulpito.ceph.com/haomai-2015-11-10_11:24:27-rados-wip-haomai-testing-distro-basic-multi/. Failed jobs 1145091 and 1145178 his http://tracker.ceph.com/issues/13767 |
|
ready to merge |
|
@liewegas give a look? It has passed tests. |
| * > 0 just break, and wait for event | ||
| * < 0 need to goto fail | ||
| */ | ||
| int NetHandler::reconnect(const entity_addr_t &addr, int sd) |
There was a problem hiding this comment.
doxygen comments are normally put into the header file. and should be started with /**, see src/mon/Monitor.h for more examples.
Fixes: ceph#12802 Signed-off-by: Jianhui Yuan <zuiwanyuan@gmail.com>
zuiwanyuan
force-pushed
the
wip-nonblock-connect
branch
from
2994073
to
0fd8de3
Compare
liewegas
added a commit
that referenced
this pull request
Nov 13, 2015
msg/async: support of non-block connect in async messenger Reviewed-by: Haomai Wang <haomai@xsky.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg/async: support of non-block connect in async messenger
Fixes: #12802
Signed-off-by: Jianhui Yuan zuiwanyuan@gmail.com