hammer: common: ThreadPool add/remove work queue methods not thread safe #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods were not acquiring the ThreadPool lock when manipulating the work_queue collection. This was causing occasional crashes within librbd when opening and closing images. Fixes: ceph#12662 Backport: hammer, firefly Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 3e18449)
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 8, 2015
…t thread safe Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@jdurgin does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-11 and for details ). |
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Nov 4, 2015
ThreadPool add/remove work queue methods not thread safe Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ThreadPool add/remove work queue methods not thread safe Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ThreadPool add/remove work queue methods not thread safe Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ThreadPool add/remove work queue methods not thread safe Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ThreadPool add/remove work queue methods not thread safe Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13042