hammer: osd: hit set clear repops fired in same epoch as map change -- segfault since they fall into the new interval even though the repops are cleared #5890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Abhishekvrshny could you git commit --amend and re-push ? Just for the sake of re-triggering the bot. I think this is a false negative. |
Otherwise, the is_active() checks in the hitset code can erroneously return true firing off repops stamped with the new epoch which then get cleared in the map change code. The filestore callbacks then pass the interval check and call into a destroyed repop structure. Fixes: 12809 Backport: hammer,firefly Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 14e02bc)
Abhishekvrshny
force-pushed
the
wip-13037-hammer
branch
from
500189d
to
8ee93d5
Compare
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 8, 2015
… map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-11 and for details ). |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Nov 10, 2015
hit set clear repops fired in same epoch as map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
hit set clear repops fired in same epoch as map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Sage Weil <sage@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
hit set clear repops fired in same epoch as map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Sage Weil <sage@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
hit set clear repops fired in same epoch as map change -- segfault since they fall into the new interval even though the repops are cleared Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13037