fix MOSDOp encoding #6174
Merged
fix MOSDOp encoding #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
|
lgtm with a nit which might not make any sense. |
Signed-off-by: Sage Weil <sage@redhat.com>
|
@tchaikov I cleaned this up, and fixed the v6 case too (which was totally broken.. reqid is at the very end!). This'll need to go through some upgrade tests before merging, but see if it looks right first? |
| features(feat) { | ||
| set_tid(tid); | ||
|
|
||
| // also put the client_inc in reqid.inc, so that get_reqid() can | ||
| // be used before the full message is decode. |
|
lgtm other than a typo and the order of checking |
We can't avoid this because we need the reqid before we've done the full decoding, and that is at the very end of v6. Too bad, so sad! Signed-off-by: Sage Weil <sage@redhat.com>
Normally, we don't fill in reqid at all (it's only for proxied ops). But we need the reqid from the partial decode. Put client_inc in reqid.inc when encoding the new format, and when decoding the old formats. Then fabricate the correct reqid in get_reqid(). Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-13345
branch
2 times, most recently
from
5563183
to
0bf2a79
Compare
|
fixed those 2 things, thanks! |
|
lgtm after the qa run passes. |
liewegas
added a commit
that referenced
this pull request
Oct 20, 2015
fix MOSDOp encoding Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using clenit_id in print() even though it was not decoded,
and the reqid handling was semi-broken.