hammer: common: wrong conditional for boolean function KeyServer::get_auth() #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KeyServer class has a public method get_auth() that returns a boolean value. This value is being checked here - fix the conditional so it triggers when get_auth() returns false. http://tracker.ceph.com/issues/9756 References: ceph#9756 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 7250db6)
|
@tchaikov does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-15 and for details ). |
|
@dachary lgtm |
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
wrong conditional for boolean function KeyServer::get_auth() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13425