crush: validate bucket id before indexing buckets array #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
I'll add a test to make sure I get it in detail. |
|
passed wip-sage-testing run |
|
I thought it was about as well. But it looks like this is just a normal case of a ruleset that has not enough buckets and the multistep rule is valid. Assuming the commit message of a31dbe2 is updated to make that clear to the reader, Reviewed-by: Loic Dachary <ldachary@redhat.com> |
We were indexing the buckets array without verifying the index was within the [0,max_buckets) range. This could happen because a multistep rule does not have enough buckets and has CRUSH_ITEM_NONE for an intermediate result, which would feed in CRUSH_ITEM_NONE and make us crash. Fixes: ceph#13477 Signed-off-by: Sage Weil <sage@redhat.com>
Ensure that the take argument is a valid bucket ID before indexing the buckets array. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added a commit
that referenced
this pull request
Oct 28, 2015
crush: validate bucket id before indexing buckets array Reviewed-by: Loic Dachary <ldachary@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13477