Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicatedPG: result code not correctly set in some cases. #6347

Merged
merged 1 commit into from Nov 11, 2015
Merged

ReplicatedPG: result code not correctly set in some cases. #6347

merged 1 commit into from Nov 11, 2015

Conversation

xiexingguo
Copy link
Member

In ReplicatedPG::do_osd_ops(), the result code is not correctly set in some cases and may mislead caller.
Fixes: #13566
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8561/

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8568/

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8630/

@tchaikov
Copy link
Contributor

@xiexingguo could you squash the commit of 962307e into 40219ca , and repush?

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8640/

@tchaikov
Copy link
Contributor

@xiexingguo and your Signed-off-by: line does not look right. see https://github.com/ceph/ceph/blob/master/SubmittingPatches#L62 . for more examples, please run "git log".

@xiexingguo
ReplicatedPG: result code not correctly set in some cases.
3b5d54b 
In ReplicatedPG::do_osd_ops(), the result code is not correctly set in some cases and may mislead caller.
Fixes: #13566
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8652/

@tchaikov tchaikov self-assigned this Oct 27, 2015
@tchaikov
Copy link
Contributor

lgtm with a rados qa run,.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 4, 2015

@xiexingguo, we just need to run this pr through a rados qa suite. normally we can help to facilitate this process: collect some pull requests and run them in a batch, and this approach suffers from relative long latency when it comes to non-urgent bug fixes. but you can also run the test in your own teuthology testbed and post the link to the tests here. if you want to learn more about teuthology and ceph-qa-suite, please join #ceph-devel and feel free to ping me.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 5, 2015

@xiexingguo, you might want to refer https://ceph.com/resources/mailing-list-irc/ for more details on the irc channel #ceph-devel .

liewegas added a commit that referenced this pull request Nov 11, 2015
@liewegas
Merge pull request #6347 from xiexingguo/xxg-wip-13566
c8e47d1 
osd: fixes for several cases where op result code was not checked or set

Reviewed-by: Kefu Chai <kchai@redhat.com>
@liewegas liewegas merged commit c8e47d1 into ceph:master Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchaikov tchaikov

Labels
bug-fix core needs-qa wip-sage-testing
Projects
None yet
Milestone
No milestone
4 participants
@xiexingguo @loic-bot @tchaikov @liewegas