hammer: rgw: orphan tool should be careful about removing head objects #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ceph#12958 Head objects are mutable, so removing them can race with object removal and a later recreation, so we might end up cleaning them up when we don't need to. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 030f697)
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 13, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 13, 2015
…moving head objects Reviewed-by:
ghost
pushed a commit
that referenced
this pull request
Nov 16, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-23 ). |
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2015
…moving head objects Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa ping ? |
|
@dachary looks good |
ghost
pushed a commit
that referenced
this pull request
Dec 2, 2015
rgw: orphan tool should be careful about removing head objects Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13538