optimize clone write path if object-map is enabled #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xinxinsh I would initialize your "object exists" variable (named with |
xinxinsh
force-pushed
the
wip-13500
branch
2 times, most recently
from
b36f390
to
89ce1da
Compare
xinxinsh
force-pushed
the
wip-13500
branch
2 times, most recently
from
46c200a
to
6338253
Compare
| m_state = LIBRBD_AIO_WRITE_GUARD; | ||
| complete(-ENOENT); | ||
| } else { | ||
| m_state = LIBRBD_AIO_WRITE_FLAT; |
There was a problem hiding this comment.
Now that I think about this more, perhaps we should keep the guarded write in the case just to be extra-safe. That would allow you to combine this block with the "m_object_exists" condition block.
xinxinsh
force-pushed
the
wip-13500
branch
2 times, most recently
from
bdde6eb
to
2430b0f
Compare
|
@dillaman ， updated, help review |
added 2 commits
November 6, 2015 09:02
Fixes : ceph#13500 Signed-off-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: xinxin shu <xinxin.shu@intel.com>
xinxinsh
force-pushed
the
wip-13500
branch
2 times, most recently
from
3c78d7d
to
33aabf2
Compare
|
@dillaman ， updated |
|
LGTM -- I'll run it through tests tomorrow |
dillaman
pushed a commit
that referenced
this pull request
Nov 9, 2015
optimize clone write path if object-map is enabled Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #13500
Signed-off-by: xinxin shu xinxin.shu@intel.com