rgw: fix the quota check when S3 multipart upload #6460
Conversation
|
for instance : @yehudasa could you take a look? thanks! |
|
@yehudasa ping |
|
@Aran85 I'm not sure this is a good idea. This can be taken advantage of by users that would upload infinite amount of data by creating multipart uploads without completing. We do want to account that data even if the upload is not complete. |
|
@yehudasa maybe the --max-size option will works when anyone upload infinite amount of data by creating multipart uploads? |
|
ping @yehudasa |
when the remainder quota of one bucket exceed the maxnum's 95%,then the next file upload can't succeed if it's multipart num more than maxnum's 5%. chang the quota check timing,only multi post request check quota,multi put will not check obj num again. Fix: ceph#13223 Signed-off-by: Zengran Zhang <zhangzengran@h3c.com>
|
@Aran85 looking at it again, I still don't think we should be doing it. The num_objs might not reflect the exact number of complete objects, but that's really ok. It can't really ever be very accurate. When dealing with small numbers it is very noticeable, but practically the num_objs limit should be set to a much higher number, so the inaccuracy due to in-flight uploads is negligible. |
|
@yehudasa can we make a Independent check for every single multi upload's parts num? or close this PR? |
|
@Aran85 not sure if I understand what you mean by independent check for every single multi upload's part num. Maybe when completing / aborting a multipart upload we need to deal with the accounting correctly? |
|
the completing/aborting of multipart upload works well now :). bc i think the rules of quota check a little hard to explain. |
|
@Aran85 what is the status of this PR? |
|
@yehudasa have no idea about treat it as bug or strategy. |
|
Closing this, feel free to reopen if it should be resurrected! |
when the remainder quota of one bucket exceed the maxnum's 95%,then the next file upload can't succeed if it's multipart num more than maxnum's 5%.
chang the quota check timing,only multi post request check quota,multi put will not check obj num again.
Fix: #13223
Signed-off-by: Zengran Zhang zhangzengran@h3c.com