Build internal plugins and classes as modules #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erasure coding plugins and Ceph classes are never exposed outside of the Ceph codebase, so versioning the built libraries adds limited value and does not reflect actual usage. Build as un-versioned shared modules instead. Signed-off-by: James Page <james.page@ubuntu.com>
javacruft
force-pushed
the
wip/ec-modules
branch
from
4d73220
to
400b0f4
Compare
ghost
self-assigned this
|
building at http://ceph.com/gitbuilder.cgi under the branch javacruft-wip-ec-modules to verify all are happy about the change |
ghost
pushed a commit
that referenced
this pull request
Nov 12, 2015
Build internal plugins and classes as modules Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasure coding plugins and Ceph classes are never exposed outside of the Ceph codebase, so versioning the built libraries adds limited value and does not reflect actual usage.
Build as un-versioned shared modules instead.