AsyncConnection: Let receiver ack message ASAP #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently dispatchers may exists logic requires ack message ASAP in order to avoid sender resend messages when socket error. Fix #136666 Signed-off-by: Haomai Wang <haomai@xsky.com>
|
Tested in http://pulpito.ceph.com/haomai-2015-11-10_11:24:27-rados-wip-haomai-testing-distro-basic-multi/. Failed jobs 1145091 and 1145178 his http://tracker.ceph.com/issues/13767 |
|
ready to merge |
@yuyuyu101 is there a ticket open to fix this ? I'm experiencing the same errors when running tests on hammer. |
|
@liewegas give a look? It has passed tests. |
liewegas
added a commit
that referenced
this pull request
Nov 13, 2015
msg/async: let receiver ack message ASAP Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dispatchers may exists logic requires ack message ASAP in order to
avoid sender resend messages when socket error.
Fix #136666
Signed-off-by: Haomai Wang haomai@xsky.com