librbd: perf section name: use hyphen to separate components #6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ceph --admin-daemon $(rbd_watch_asok ${image}) perf dump | | ||
| sed -ne 's/^.*"'${counter}'": \([0-9]*\).*$/\1/p' | ||
| name=$(ceph --format xml --admin-daemon $(rbd_watch_asok ${image}) \ | ||
| perf schema | $XMLSTARLET el -d3 | |
There was a problem hiding this comment.
missing the definition of XMLSTARLET, otherwise looks good
There was a problem hiding this comment.
XMLSTARLET is defined in qa/workunits/ceph-helpers.sh, which is included above.
There was a problem hiding this comment.
ah, missed that. will merge in the morning
added 2 commits
November 11, 2015 09:19
"/" and "@" characters make invalid xml format output. Fixes: ceph#13719 Signed-off-by: Mykola Golub <mgolub@mirantis.com>
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
|
Rebased to kick make check bot. |
jdurgin
added a commit
that referenced
this pull request
Nov 11, 2015
librbd: perf section name: use hyphen to separate components Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"/" and "@" characters make invalid xml format output.
Fixes: #13719
Signed-off-by: Mykola Golub mgolub@mirantis.com