Reduce CPU usage by reusing stringstream in stringify function #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion About 10% CPU reduction and 10% TPS bump in CPU bound workload. Signed-off-by: Evgeniy Firsov <evgeniy.firsov@sandisk.com>
|
@efirs , what tools do you use to generate this image? is it public? |
It is Intel vtune. |
Signed-off-by: Evgeniy Firsov <evgeniy.firsov@sandisk.com>
|
LGTM... but the performance difference is still a shock to me. The perf is applied in the osd process level or a specified thread? |
|
@yuyuyu101 Its full osd process profile. |
liewegas
added a commit
that referenced
this pull request
Nov 28, 2015
common: reduce CPU usage by making stringstream in stringify function thread local Reviewed-by: Haomai Wang <haomai@xsky.com> Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 10% CPU reduction and 10% TPS bump in CPU bound workload.
Blanks in the fourth column is saved CPU after the change.