hammer: osd: smaller object_info_t xattrs #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-smaller-object-info
branch
from
9398e03
to
c7b5057
Compare
liewegas
changed the title
liewegas
force-pushed
the
wip-smaller-object-info
branch
2 times, most recently
from
c2ced2e
to
17a217c
Compare
|
This seems reasonable to me, but should go into master first? |
|
I don't want to put it in master at all since we're throwing out
local_mtime (so it's not strictly optimal) and master is smart enough to
stripe these across smaller inlined xattrs.
|
|
@liewegas could you please rebase & repush ? |
liewegas
force-pushed
the
wip-smaller-object-info
branch
from
17a217c
to
9a7f4f7
Compare
liewegas
force-pushed
the
wip-smaller-object-info
branch
from
9a7f4f7
to
2895bb6
Compare
|
@liewegas would you mind rebasing & repushing to get a new run of the bot ? |
liewegas
force-pushed
the
wip-smaller-object-info
branch
from
2895bb6
to
6889f99
Compare
| !has_flag(DATA_DIGEST) && | ||
| watchers.empty()) { // no watchers | ||
| // note: we dropped local_mtime too, even though it may have been used. | ||
| ev = 10; |
There was a problem hiding this comment.
assert omap_digest == -1 and data_digest == -1?
liewegas
force-pushed
the
wip-smaller-object-info
branch
7 times, most recently
from
7f2d967
to
aff84b4
Compare
We want to avoid encoding it if we can. And if the FLAG_OMAP is not set we don't need to *also* store an empty crc. Signed-off-by: Sage Weil <sage@redhat.com>
If we don't have a local_mtime value, use mtime instead, for the purposes of deciding if we should record a digest after scrub. Signed-off-by: Sage Weil <sage@redhat.com>
If a pool isn't tiered, don't bother with setting local_mtime. The only users are the tiering agent (which isn't needed if there is not tiering) and scrub for deciding if an object should get its digest recorded (we can use mtime instead). Signed-off-by: Sage Weil <sage@redhat.com>
…nused This reduces the size of the encoded object_info_t in most cases, enough to get us under the 255 byte limit for a single inline xattr in XFS. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-smaller-object-info
branch
from
aff84b4
to
a9d3f07
Compare
|
I think this looks right |
liewegas
added a commit
that referenced
this pull request
Dec 17, 2015
osd: make encoded object_info_t smaller to fit inside the XFS inode Reviewed-by: Samuel Just <sjust@redhat.com>
|
Still need to run upgrade/hammer-x test; do not release or take this downstream yet. |
|
Ok do you want to update this PR to communicate the status? |
|
Yeah, and I'll ping you too :)
|
|
Passed the hammer-x upgrade. Good to go! http://pulpito.ovh.sepia.ceph.com:8081/sage-2015-12-17_20:33:10-upgrade:hammer-x-infernalis---basic-openstack/ |
ktdreyer
changed the title
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14803
Avoid later bits of object_info_t encoding ot reduce the xattr size, so that it can be inlined by xfs (< 255 bytes).
We lose: