osd: check do_shutdown before do_restart #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will save extart boot message when do_shutdown && do_restart == true, which is the case when rebind failed. Also move the unlock/lock inside the if statement so we don't do unnecessary lock/unlock. Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
|
lgtm. but seems we don't have any test to exercise this code path though. |
|
you are right, i'm not sure we have tests to cover those two cases either. i manually tested the change locally. removing "bug fix" as it does not address a known issue, and adding "needs-qa" to perform the sanity tests. |
liewegas
added a commit
that referenced
this pull request
Nov 15, 2015
osd: check do_shutdown before do_restart Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
added
the
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will save extart boot message when do_shutdown && do_restart == true,
which is the case when rebind failed.
Also move the unlock/lock inside the if statement so we don't do unnecessary
lock/unlock.
Signed-off-by: Xiaoxi Chen xiaoxi.chen@intel.com