rbd: accept --user, refuse -i #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--user is the equivalent of --id (mentioned in docs and ceph -h) and used by at least a couple of qa scripts and teuthology. Add it to the list of valid rbd options - it's handled inside global_init() before Shell:execute() is called. OTOH allowing -i is bogus - global_init() wouldn't process it for clients (CEPH_ENTITY_TYPE_CLIENT), which rbd tool is one of. Drop it. Signed-off-by: Ilya Dryomov <idryomov@redhat.com>
dillaman
pushed a commit
that referenced
this pull request
Nov 16, 2015
rbd: accept --user, refuse -i command-line optionals Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--user is the equivalent of --id (mentioned in docs and ceph -h) and
used by at least a couple of qa scripts and teuthology. Add it to the
list of valid rbd options - it's handled inside global_init() before
Shell:execute() is called.
OTOH allowing -i is bogus - global_init() wouldn't process it for
clients (CEPH_ENTITY_TYPE_CLIENT), which rbd tool is one of. Drop it.
Signed-off-by: Ilya Dryomov idryomov@redhat.com