Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update ceph-disk manual page with new feature deactivate/destroy. #6637

Merged
2 commits merged into from Nov 19, 2015

Conversation

Vicente-Cheng
Copy link
Contributor

  • Update the ceph-disk manual page

Signed-off-by: Vicente Cheng freeze.bilsted@gmail.com

@ghost ghost self-assigned this Nov 18, 2015
@@ -32,6 +38,10 @@ It actually automates the multiple steps involved in manual creation and start
of an OSD into two steps of preparing and activating the OSD by using the
subcommands ``prepare`` and ``activate``.

Futhermore, now :program:`ceph-disk` also automates the multiple steps invloved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Futhermore, now//

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/invloved/involved/

@Vicente-Cheng
Copy link
Contributor Author

Hi @dachary,
thanks for your review!!!

I have done the above sugggestions :p

And should I pull another request to remove --mark-init and --activate-key ?

thanks
vicente

@ghost
Copy link

ghost commented Nov 18, 2015

And should I pull another request to remove --mark-init and --activate-key ?

It should be enough to make them in a separate commit.

@@ -32,6 +38,10 @@ It actually automates the multiple steps involved in manual creation and start
of an OSD into two steps of preparing and activating the OSD by using the
subcommands ``prepare`` and ``activate``.

:program:`ceph-disk` also automates the multiple steps involved
in manual stop and destroy of an OSD into two steps of deactivating and destroying
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/in manual stop and destroy of an OSD/to manually stop and destroy an OSD/

@@ -97,6 +107,13 @@ Usage::
If the option :option:`--no-start-daemon` is given, the activation
steps are performed but the OSD daemon is not started.

The latest option :option:`--reactivate` can re-activate the osd which has been
deactivated with the deactivate subcommand.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word deactivate should be in quotes as when other subcommands are cited ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be!!

thanks for reminder 👍

  - Update the ceph-disk manual page

Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
  - remove `--mark-init` and `--activate-key` from options because
    they are not options that are common to all subcommands.

Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
@Vicente-Cheng
Copy link
Contributor Author

hi @dachary

It should be enough to make them in a separate commit.

I separate a commit for remove --mark-init and --activate-key from options and correct the nits for previous ceph-disk manual page.

thanks!!!
vicente

ghost pushed a commit that referenced this pull request Nov 19, 2015
doc: Update ceph-disk manual page with new feature deactivate/destroy.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit b2f2e6c into ceph:master Nov 19, 2015
@Vicente-Cheng Vicente-Cheng deleted the update-ceph-disk-manual-page branch November 20, 2015 09:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants