New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update ceph-disk manual page with new feature deactivate/destroy. #6637
Conversation
@@ -32,6 +38,10 @@ It actually automates the multiple steps involved in manual creation and start | |||
of an OSD into two steps of preparing and activating the OSD by using the | |||
subcommands ``prepare`` and ``activate``. | |||
|
|||
Futhermore, now :program:`ceph-disk` also automates the multiple steps invloved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Futhermore, now//
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/invloved/involved/
8fbd877
to
bdbd612
Compare
Hi @dachary, I have done the above sugggestions :p And should I pull another request to remove thanks |
It should be enough to make them in a separate commit. |
@@ -32,6 +38,10 @@ It actually automates the multiple steps involved in manual creation and start | |||
of an OSD into two steps of preparing and activating the OSD by using the | |||
subcommands ``prepare`` and ``activate``. | |||
|
|||
:program:`ceph-disk` also automates the multiple steps involved | |||
in manual stop and destroy of an OSD into two steps of deactivating and destroying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/in manual stop and destroy of an OSD/to manually stop and destroy an OSD/
@@ -97,6 +107,13 @@ Usage:: | |||
If the option :option:`--no-start-daemon` is given, the activation | |||
steps are performed but the OSD daemon is not started. | |||
|
|||
The latest option :option:`--reactivate` can re-activate the osd which has been | |||
deactivated with the deactivate subcommand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word deactivate should be in quotes as when other subcommands are cited ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be!!
thanks for reminder 👍
- Update the ceph-disk manual page Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
- remove `--mark-init` and `--activate-key` from options because they are not options that are common to all subcommands. Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
bdbd612
to
1633d3e
Compare
hi @dachary
I separate a commit for remove thanks!!! |
doc: Update ceph-disk manual page with new feature deactivate/destroy. Reviewed-by: Loic Dachary <ldachary@redhat.com>
Signed-off-by: Vicente Cheng freeze.bilsted@gmail.com