Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: macro fix #6769

Merged
merged 1 commit into from Dec 2, 2015
Merged

configure.ac: macro fix #6769

merged 1 commit into from Dec 2, 2015

Conversation

aiicore
Copy link
Contributor

@aiicore aiicore commented Dec 2, 2015

Configure fails with autoconf 2.63 on Centos 6.6 with:

./configure: line 34026: syntax error near unexpected token``newline'
./configure: line 34026:``yes:no:'

Signed-off-by: Igor Podoski igor.podoski@ts.fujitsu.com

Configure fails with autoconf 2.63 on Centos 6.6 with:

./configure: line 34026: syntax error near unexpected token `newline'
./configure: line 34026: `  yes:no:'

Signed-off-by: Igor Podoski <igor.podoski@ts.fujitsu.com>
@b-ranto
Copy link
Contributor

b-ranto commented Dec 2, 2015

@alicore: I'm not sure how much this helps you with CentOS 6 support. The SELinux stuff won't work in CentOS 6 (well, at least not before 6.8) and there might also be some other issues (lacking support for C++ 11 features in CentOS 6 comes to mind).

Anyway, lgtm.

@aiicore
Copy link
Contributor Author

aiicore commented Dec 2, 2015

@BRANTO1 Hey, I use devtoolset to compile ceph with C++11 on Centos 6.6, it's working.

@b-ranto b-ranto self-assigned this Dec 2, 2015
@b-ranto
Copy link
Contributor

b-ranto commented Dec 2, 2015

OK, in that case, I suppose we can merge it right away given the simple nature of the fix and the fact that it passed the jenkins build.

b-ranto added a commit that referenced this pull request Dec 2, 2015
configure.ac: macro fix

Reviewed-by: Boris Ranto <branto@redhat.com>
@b-ranto b-ranto merged commit ca777e8 into ceph:master Dec 2, 2015
@ghost
Copy link

ghost commented Dec 2, 2015

@BRANTO1 I don't think the gitbuilders / make check bot try --with-eventfd, I guess it will have to be manually tested on various operating system. Unless it is the default and is always run ?

@b-ranto
Copy link
Contributor

b-ranto commented Dec 2, 2015

@dachary: It is the default.

See configure.ac or e.g. help for ./configure:
--without-eventfd -- disable eventfd (default=no)

@aiicore aiicore deleted the configure_fix branch December 2, 2015 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants