Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: re-enable backtrace support #6771

Merged
1 commit merged into from Dec 2, 2015
Merged

Conversation

dillaman
Copy link

@dillaman dillaman commented Dec 2, 2015

A recent porting effort disabled support for backtrace creation. It
also didn't initialize all variables, which would lead to a crash when
deleting a backtrace instance.

Signed-off-by: Jason Dillaman dillaman@redhat.com

A recent porting effort disabled support for backtrace creation.  It
also didn't initialize all variables, which would lead to a crash when
deleting a backtrace instance.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@ghost ghost self-assigned this Dec 2, 2015
@ghost
Copy link

ghost commented Dec 2, 2015

For the record the commit that disabled backtrace is dillaman@a3a0e1c#diff-e52b70b128d4dd40c5ae68e8e49c5b4aR2

ghost pushed a commit that referenced this pull request Dec 2, 2015
common: re-enable backtrace support

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit e5c9e20 into ceph:master Dec 2, 2015
@ghost
Copy link

ghost commented Dec 2, 2015

@dillaman we need this in jewel as well ?

@dillaman
Copy link
Author

dillaman commented Dec 2, 2015

@dachary Negative -- it was only changed recently on the master branch, jewel branch is correct.

@ghost
Copy link

ghost commented Dec 2, 2015

@dillaman good. It must have been a lot of fun tracking this one down :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants