osd: call on_new_interval on newly split child PG #6778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must call on_new_interval() on any interval change *and* on the creation of the PG. Currently we call it from PG::init() and PG::start_peering_interval(). However, PG::split_into() did not do so for the child PG, which meant that the new child feature bits were not properly initialized and the bitwise/nibblewise debug bit was not correctly set. That, in turn, could lead to various misbehaviors, the most obvious of which is scrub errors due to the sort order mismatch. Fixes: ceph#13962 Signed-off-by: Sage Weil <sage@redhat.com>
|
passed an initial round of tests |
|
LGTM |
liewegas
added a commit
that referenced
this pull request
Dec 4, 2015
osd: call on_new_interval on newly split child PG Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must call on_new_interval() on any interval change and on the
creation of the PG. Currently we call it from PG::init() and
PG::start_peering_interval(). However, PG::split_into() did not
do so for the child PG, which meant that the new child feature
bits were not properly initialized and the bitwise/nibblewise
debug bit was not correctly set. That, in turn, could lead to
various misbehaviors, the most obvious of which is scrub errors
due to the sort order mismatch.
Fixes: #13962
Signed-off-by: Sage Weil sage@redhat.com