cmake: Add common/PluginRegistry.cc to CMakeLists.txt #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else this happens: [ 15%] Linking CXX executable ceph-authtool libcommon.a(ceph_context.cc.o): In function `CephContext::CephContext(unsigned int, int)': ceph_context.cc:(.text+0x2620): undefined reference to `ceph::PluginRegistry::PluginRegistry(CephContext*)' libcommon.a(ceph_context.cc.o): In function `CephContext::~CephContext()': ceph_context.cc:(.text+0x3db0): undefined reference to `ceph::PluginRegistry::~PluginRegistry()' collect2: error: ld returned 1 exit status src/CMakeFiles/ceph-authtool.dir/build.make:120: recipe for target 'src/ceph-authtool' failed make[2]: *** [src/ceph-authtool] Error 1 CMakeFiles/Makefile2:331: recipe for target 'src/CMakeFiles/ceph-authtool.dir/all' failed The ceph_context.cc is the only user of PluginRegistry at present, so adding it without conditionals should be correct. Signed-Off-By: Pete Zaitcev <zaitcev@redhat.com>
|
lgtm |
oritwas
added a commit
that referenced
this pull request
Dec 7, 2015
cmake: Add common/PluginRegistry.cc to CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is like this:
libcommon.a(ceph_context.cc.o): In function
CephContext::CephContext(unsigned int, int)': ceph_context.cc:(.text+0x2620): undefined reference toceph::PluginRegistry::PluginRegistry(CephContext*)'